Skip to content

Enable strip-types transform for internal code#2708

Merged
zpao merged 1 commit intofacebook:masterfrom
zpao:strip-types
Dec 14, 2014
Merged

Enable strip-types transform for internal code#2708
zpao merged 1 commit intofacebook:masterfrom
zpao:strip-types

Conversation

@zpao
Copy link
Member

@zpao zpao commented Dec 14, 2014

Flow is coming so we need to be ready.

Somebody started writing a diff adding types to keyMirror which doesn't build. So I tested that this does:

diff --git a/src/utils/keyMirror.js b/src/utils/keyMirror.js
index 0e0c614..eaaa5f0 100644
--- a/src/utils/keyMirror.js
+++ b/src/utils/keyMirror.js
@@ -32,7 +32,11 @@ var invariant = require('invariant');
  * @param {object} obj
  * @return {object}
  */
-var keyMirror = function(obj) {
+function keyMirror<T>(obj: T): T {
+ return keyMirrorInternal(obj);
+}
+
+function keyMirrorInternal(obj) {
   var ret = {};
   var key;
   invariant(

Flow is coming so we need to be ready.
@sophiebits
Copy link
Collaborator

👍

zpao added a commit that referenced this pull request Dec 14, 2014
Enable strip-types transform for internal code
@zpao zpao merged commit ca5d93c into facebook:master Dec 14, 2014
@zpao zpao deleted the strip-types branch April 16, 2015 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants